-
Notifications
You must be signed in to change notification settings - Fork 48
STACKITLB-798 | add ALB TF provider #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
imo we should use |
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
7db8e97 to
ac05133
Compare
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
| Validators: []validator.String{ | ||
| stringvalidator.LengthBetween(4, 6), | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove also the LengthBetween validator. We don't have for any resource a validation of the region and I prefer that we keep this consistent for alb
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
eab55b8 to
7dd76db
Compare
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
| // loadbalancer terraform ID: = "[project_id],[name]" | ||
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1] | ||
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong structure of the ID
| // loadbalancer terraform ID: = "[project_id],[name]" | |
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1] | |
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) | |
| // loadbalancer terraform ID: = "[project_id],[region],[name]" | |
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[2] | |
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) |
|
Please check the failing CI pipeline |
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
edee1ce to
35e0675
Compare
35e0675 to
b7bf33e
Compare
Description
STACKITLB-798
Add Application Load Balancer provider (API: https://docs.api.stackit.cloud/documentation/alb/version/v2)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)