Skip to content

Conversation

@david-mey-STACKIT
Copy link

Description

STACKITLB-798

Add Application Load Balancer provider (API: https://docs.api.stackit.cloud/documentation/alb/version/v2)

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex
Copy link
Contributor

h3adex commented Feb 6, 2026

imo we should use stackit_application_loadbalancer instead of stackit_alb as resource/datasource naming.

david-mey-STACKIT added a commit to david-mey-STACKIT/terraform-provider-stackit that referenced this pull request Feb 9, 2026
Comment on lines 531 to 533
Validators: []validator.String{
stringvalidator.LengthBetween(4, 6),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this validator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove also the LengthBetween validator. We don't have for any resource a validation of the region and I prefer that we keep this consistent for alb

Comment on lines 646 to 648
// loadbalancer terraform ID: = "[project_id],[name]"
loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1]
loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong structure of the ID

Suggested change
// loadbalancer terraform ID: = "[project_id],[name]"
loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1]
loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName)
// loadbalancer terraform ID: = "[project_id],[region],[name]"
loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[2]
loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName)

@marceljk
Copy link
Contributor

Please check the failing CI pipeline

Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
@david-mey-STACKIT david-mey-STACKIT force-pushed the main branch 8 times, most recently from edee1ce to 35e0675 Compare February 11, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants