Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Dec 19, 2025

Description

relates to STACKITTPR-413 and #1045

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner December 19, 2025 15:02
relates to STACKITTPR-413 and #1045
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-413-iaas-volume-encryption branch from 98d324f to e6b092c Compare December 19, 2025 15:05
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume 25.31% (+10.10%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume/datasource.go 41.56% (+41.56%) 77 (+37) 32 (+32) 45 (+5) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume/resource.go 20.16% (+2.37%) 243 (+7) 49 (+7) 194 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/iaas_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume/resource_test.go

validate.NoSeparator(),
},
},
"key_payload_base64": schema.StringAttribute{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key_payload_base64 can be set as WriteOnly attribute. Most providers offer both options, so a normal field and a WriteOnly field.
Because the WriteOnly isn't stored in the state, we would need a WriteOnlyVersion field as well. When the version field changes, a replaces can be triggered.
See https://developer.hashicorp.com/terraform/language/manage-sensitive-data/write-only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants