Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Dec 18, 2025

Description

context.Context is call-by-value (as basically everything in Golang), so the updated context has to be returned

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner December 18, 2025 10:49
@rubenhoenle rubenhoenle self-assigned this Dec 18, 2025
@rubenhoenle rubenhoenle force-pushed the fix/set-and-log-state-fields-util branch from f3a0189 to 8bedab6 Compare December 18, 2025 14:34
@rubenhoenle rubenhoenle enabled auto-merge (squash) December 18, 2025 14:34
@rubenhoenle rubenhoenle merged commit 459122c into main Dec 18, 2025
3 checks passed
@rubenhoenle rubenhoenle deleted the fix/set-and-log-state-fields-util branch December 18, 2025 14:37
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/.github/docs/contribution-guide 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset 20.26% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone 21.05% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/affinitygroup 11.80% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image 37.43% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearegion 31.15% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearoute 20.42% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterface 25.97% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterfaceattach 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/publicip 12.22% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/publicipassociate 11.97% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygroup 11.76% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygrouprule 25.98% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server 31.16% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/serviceaccountattach 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume 15.22% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volumeattach 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key 12.17% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring 10.59% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key 14.51% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 82.46% (+0.16%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/.github/docs/contribution-guide/resource.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset/resource.go 24.74% (ø) 190 47 143
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone/resource.go 27.51% (ø) 189 52 137
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/affinitygroup/resource.go 15.11% (ø) 139 21 118
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image/resource.go 32.01% (ø) 278 89 189
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearegion/resource.go 35.32% (ø) 269 95 174
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkarearoute/resource.go 23.89% (ø) 247 59 188
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterface/resource.go 30.19% (ø) 265 80 185
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterfaceattach/resource.go 0.00% (ø) 119 0 119
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/publicip/resource.go 14.92% (ø) 181 27 154
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/publicipassociate/resource.go 11.97% (ø) 142 17 125
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygroup/resource.go 14.36% (ø) 181 26 155
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygrouprule/resource.go 33.46% (ø) 257 86 171
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/server/resource.go 26.97% (ø) 393 106 287
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/serviceaccountattach/resource.go 0.00% (ø) 119 0 119
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volume/resource.go 17.80% (ø) 236 42 194
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/volumeattach/resource.go 0.00% (ø) 117 0 117
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key/resource.go 15.44% (ø) 149 23 126
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/resource.go 13.74% (ø) 131 18 113
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/resource.go 18.30% (ø) 153 28 125
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils.go 79.41% (+0.31%) 68 (+1) 54 (+1) 14 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants