Skip to content

feat(sfs): Refactor wait handler to use new WaiterHelper#7231

Merged
j1n-o9r merged 8 commits into
mainfrom
feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper
Jun 1, 2026
Merged

feat(sfs): Refactor wait handler to use new WaiterHelper#7231
j1n-o9r merged 8 commits into
mainfrom
feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper

Conversation

@j1n-o9r
Copy link
Copy Markdown
Contributor

@j1n-o9r j1n-o9r commented May 11, 2026

Description

Update the wait handler of sfs, to use the new WaiterHelper struct. Replace every possible wait handler implementation of this service, to use just the WaiterHelper.

relates to STACKITSDK-368

Testing Instruction

  • checkout feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper

  • run make test

  • go to your terraform repo and add this line to go mod, adjust path to sdk if necessary
       replace github.com/stackitcloud/stackit-sdk-go/services/sfs => ../stackit-sdk-go/services/sfs

  • run tf acceptance tests for sfs

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch from 185defd to 4d4e5e6 Compare May 13, 2026 10:00
@j1n-o9r j1n-o9r marked this pull request as ready for review May 13, 2026 10:21
@j1n-o9r j1n-o9r requested a review from a team as a code owner May 13, 2026 10:22
@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch 3 times, most recently from 1a26fa5 to e545a8d Compare May 13, 2026 10:59
Comment thread services/sfs/v1api/wait/wait.go Outdated
Comment thread services/sfs/v1api/wait/wait.go Outdated
Comment thread services/sfs/v1api/wait/wait.go Outdated
Comment thread services/sfs/v1api/wait/wait.go Outdated
Comment thread services/sfs/v1api/wait/wait.go Outdated
Comment thread services/sfs/v1api/wait/wait.go Outdated
marceljk
marceljk previously approved these changes May 20, 2026
@github-actions
Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale label May 28, 2026
@j1n-o9r j1n-o9r force-pushed the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch from e334b92 to 9858d66 Compare June 1, 2026 08:27
@j1n-o9r j1n-o9r merged commit cb2143b into main Jun 1, 2026
7 checks passed
@j1n-o9r j1n-o9r deleted the feat/STACKITSDK-368-refactor-wait-handler-to-use-wait-helper branch June 1, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants