Conversation
0a4a0d5 to
2e0be67
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8439761 to
8f95f5f
Compare
Co-authored-by: Felix Breuer <f.breuer94@gmail.com>
8f95f5f to
d39fd9f
Compare
|
@breuerfelix Thanks! I also ran a test in an ondemand environment testing the self-hosted shoot scenario using gardenadm (only in this case the IP is written into the |
|
/unhold |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Similar to gardener/machine-controller-manager-provider-openstack#322
Server InternalIPs are now returned on created Machines, so that they may be used for access. This is needed, as the provided hostname field already written into is the
MachineStatus.Addressesis not resolvable on STACKIT.Which issue(s) this PR fixes:
x
Special notes for your reviewer:
The
clientSuite was previously not registered and there was a small bug in one test case./hold Running tests first