Skip to content

update go to 1.26.1#56

Open
breuerfelix wants to merge 1 commit intomainfrom
update-go
Open

update go to 1.26.1#56
breuerfelix wants to merge 1 commit intomainfrom
update-go

Conversation

@breuerfelix
Copy link
Member

How to categorize this PR?

/kind technical-debt

What this PR does / why we need it:
Updates to go 1.26.1 with its latest language features

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added the kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly label Mar 18, 2026
@ske-prow
Copy link

ske-prow bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breuerfelix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 18, 2026
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix
Copy link
Member Author

/hold until tested

@ske-prow ske-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026
@breuerfelix
Copy link
Member Author

image tested in ondemand with openstack and stackit shoot

@breuerfelix
Copy link
Member Author

/unhold

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026
@breuerfelix breuerfelix requested a review from a team March 18, 2026 15:50
Copy link
Contributor

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like everywhere we use ptr.To instead of Go 1.26 new. Should we really change that? We also use ptr.Deref in some cases

Personally new is also kinda confusing to me, new what? 🤷

Is that new recommendation coming from the golangci-lint modernize plugin?

@breuerfelix
Copy link
Member Author

I feel like everywhere we use ptr.To instead of Go 1.26 new. Should we really change that? We also use ptr.Deref in some cases

Personally new is also kinda confusing to me, new what? 🤷

Is that new recommendation coming from the golangci-lint modernize plugin?

Everything changed were just recommendations by modernize and even though new reads a little weird in these use cases, it does what it used to do in other languages as well. It creates a new 'object' and returns the pointer to it.
In general in would not argue about that. It is a language feature that deprecates other libraries so we should use it.
Also the ptr.Deref is something we should still keep because we do not use it for dereferencing but rather as a defaulting function. Otherwise we could have just used & :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants