Build DOCA-OFED kernel modules for Rocky 10#2310
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for DOCA OFED on Rocky Linux 10 for both x86_64 and aarch64 architectures. The changes involve updating repository configurations, kernel version matrices, and adding retry logic for Pulp-related tasks. Feedback focuses on improving maintainability and consistency by replacing hardcoded version strings with variables in repository definitions and variable names. Additionally, it is recommended to use kolla_base_arch instead of os_arch in push-ofed.yml to ensure correct repository selection during cross-architecture builds and to maintain consistency in failure messages.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for DOCA OFED on Rocky Linux 10 for both x86_64 and aarch64 architectures. Key changes include updating the DOCA version matrix, refactoring repository lookups to be more dynamic, and adding Pulp repository configurations and DNF custom repositories for RHEL 10. Feedback focuses on correcting the use of non-standard architecture variables, ensuring Ansible retry logic is correctly implemented with 'until' and 'delay' parameters, and utilizing generic version variables in repository URLs to improve maintainability.
We build DOCA-OFED Kernel Modules for both x86_64 and aarch64 at the same time to ensure they're both on the same kernel - we need to keep Rocky repositories for both architectures in sync. for this to ensure we have necessary kernel-devel packages for the target kernel available in both.
DOCA OFED support has now been added for Rocky 10
2 participants
DOCA OFED support has now been added for Rocky 10