Move deployment/deploy-openbao-kayobe-automation.yml to secret-store/…#2227
Move deployment/deploy-openbao-kayobe-automation.yml to secret-store/…#2227maxstack wants to merge 1 commit intostackhpc/2025.1from
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates OpenBao as a secret store for GitHub and GitLab CI/CD workflows. It updates the documentation to guide users on deploying OpenBao, configuring workflows to retrieve secrets, and managing secrets/variables based on whether OpenBao is used. The Ansible playbooks for deploying and unsealing OpenBao on runners have been modified to dynamically configure network interfaces and standardize paths. Review feedback indicates that the vault_unseal_verify: false parameter is commented out in both the deploy and unseal playbooks, which could lead to failures with self-signed certificates. Additionally, a phrase in the documentation regarding 'add network IP' needs clarification, and the table for secrets when OpenBao is not used is incorrect, as it redundantly includes REGISTRY_PASSWORD and omits KAYOBE_VAULT_PASSWORD. Finally, the vault_unseal_token is unnecessarily included in the unseal playbook.
etc/kayobe/ansible/secret-store/secret-store-deploy-openbao-runners.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/ansible/secret-store/secret-store-unseal-openbao-runners.yml
Outdated
Show resolved
Hide resolved
etc/kayobe/ansible/secret-store/secret-store-unseal-openbao-runners.yml
Outdated
Show resolved
Hide resolved
cc3b6b0 to
c3c71d3
Compare
…secret-store-deploy-openbao-runners.yml This is inline with the playbooks installing vault/openbao for the seed and overcloud. Fix deployment issues with GitHub runners: * determine network interface to use, docker0 or lo * protocol missing from api_uri * general fixes so playbook's more inline with other secret-store-deploy playbooks
c3c71d3 to
fc5572d
Compare
Fixes openbao deployment issues on GitHub runner.
Also moves this deploy playbook into the secret-store ansible location alongside its unseal counterpart.
Chages made:
docker0network interface for GitHub as the kayobe automation containers can't contact the host's localhostlofor Gitlab deployments, which seems to be where this playbook was working