OS-capacity exporter should not be exposed#2219
Merged
oneswig merged 2 commits intostackhpc/2025.1from Mar 26, 2026
Merged
Conversation
The os-capacity exporter has access to admin cloud credentials and provides details of current utilisation for all OpenStack tenancies. Currently this exporter binds to all interfaces on hosts where it is deployed, which may lead to leakage of potentially important data on an unauthenticated port. Bind the exporter only to the Internal API network, from where it is usually scraped. Signed-off-by: Stig Telfer <stig@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly identifies a security risk with the os-capacity-exporter and aims to mitigate it by restricting the listen address. However, the implementation is likely to cause the service to fail because the port is missing from the listen address. I've added a specific comment with a suggested fix.
oneswig
added
good first issue
dougszumski
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The os-capacity exporter has access to admin cloud credentials and provides details of current utilisation for all OpenStack tenancies. Currently this exporter binds to all interfaces on hosts where it is deployed, which may lead to leakage of potentially important data on an unauthenticated port.
Bind the exporter only to the Internal API network, from where it is usually scraped.