Ensure rocky base image with correct minor version #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set ROCKY_MINOR_DOT_VERSION=.6
mnasiadka
reviewed
Jan 21, 2026
|
|
||
| FROM docker.io/rockylinux/rockylinux:9 | ||
| ARG ROCKY_MINOR_DOT_VERSION=.6 | ||
| FROM quay.io/rockylinux/rockylinux:9${ROCKY_MINOR_DOT_VERSION} |
Member
There was a problem hiding this comment.
That will change the default and that element might be used somewhere else we're not aware of currently.
can we just set the default version to 9, and allow changing it by using ROCKY_VERSION or something similar?
Alex-Welsh
reviewed
Jan 21, 2026
| # Based on https://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/elements/rocky-container/containerfiles/9 | ||
|
|
||
| FROM docker.io/rockylinux/rockylinux:9 | ||
| ARG ROCKY_MINOR_DOT_VERSION=.6 |
Member
There was a problem hiding this comment.
Including the "dot" in this feels a bit wierd. I'd much prefer it if was just the minor version, and the dot was added conditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used rockylinux:9 without specifying the minor version.
Also move to quay.io