Add optional chaining to 'name' in getExtension

[yuval-a]

This fixes a bug when a name can be 'null' and an exception will be thrown when calling 'getSupportedExtensions()'. This happened to me when using 'gpu.js' - which has this as a dependency. |

[dhritzkiv]

Hi @yuval-a.

Do you know under which circumstances getExtension is called without a value? Calling getExtension without an argument may be a bug in your code.

[yuval-a]

Hey Daniel. To reproduce this: npm install gpu.js (a popular general GPU programming library). run this: const gl = require('gl')(1, 1); let exts = gl.getSupportedExtensions(); console.log (exts); You will get an exception in gl that the name of an extension is undefined. I am not sure if this is a version issue - the package.json of gpu.js has an older version (4.x.x) as a dependency - however - when I set it to latest (6.0.1) - and reinstall - it still happens. BUT - if I just open a new project - and do npm install for gl - and run the code - this error does not happen - I'm not entirely sure why this happens - perhaps gpu.js has some code that explicitly changes something in the gl module "from outside"... Anyway, this fixes it for that. Yuval.

…

On Fri, 21 Oct 2022 at 23:37, Daniel Hritzkiv ***@***.***> wrote: Hi @yuval-a <https://github.com/yuval-a>. Do you know under which circumstances getExtension is called without a value? Calling getExtension without an argument may be a bug in your code. — Reply to this email directly, view it on GitHub <#238 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE5ZASBLJ5HWRIOWCQRKITWEL5H7ANCNFSM6AAAAAARLOT55E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dhritzkiv]

Hmm. I cannot reproduce this myself, even after installing gpu.js. I'm running this in nodejs on macOS. What about you?

In either case, I would suggest debugging this problem further by stepping through the code to find what calls getExtension with a non-string argument. I believe this to be a problem elsewhere, and may be indicative of a different sort of bug, possibly somewhere else in headless-gl.

[yuval-a]

Haven’t tried on macOS, just on Windows. Could be related…

[dhritzkiv]

Could be.

Still, it would helpful for you to step through the code and find where getExtension is being called without a string.