Replace texture id from Integer to NumberObject.#130
Open
anokta wants to merge 1 commit intostackgl:masterfrom
anokta:patch-1
Open
Replace texture id from Integer to NumberObject.#130anokta wants to merge 1 commit intostackgl:masterfrom anokta:patch-1
anokta wants to merge 1 commit intostackgl:masterfrom
anokta:patch-1
Conversation
Member
|
Thanks for the submission and sorry for the delay in reviewing this. I've caught up your branch with the latest state of the repo. If you may, could you please describe the equality checks in three.js you were referring to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix the reference equality checks when using three.js.