Conversation
This change is based on stackabletech/decisions#84
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
I assume this breaks things until the operator Helm templates are corrected (in the same PR that this generates?)
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
|
Good catch, I will update this PR. |
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
LGTM
There could be an operator that bypasses the helper and still refers to the image, so we will need to be careful before merging the generated PRs
Techassi
deleted the
chore/template-adjust-registry-specific-values-file
branch
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
| settings = read_json('tilt_options.json', default={}) | ||
| registry = settings.get('default_registry', 'oci.stackable.tech') | ||
| repository = settings.get('default_repository', 'sandbox' + '/' + operator_name) | ||
| repository = settings.get('default_repository', registry + '/' + 'sdp') |
There was a problem hiding this comment.
It turns out this breaks local development.
We don't want to push the operator image to sdp, but instead sandbox, but when I change it locally to sandbox the the product images fail to pull because they get set to: oci.stackable.tech/sandbox/kafka:3.9.1-stackable0.0.0-dev - but I want them to be at sdp.
I think we need to separate the concept of the operator image prefix/repo and the product prefix/repo.
3 participants
This change is based on https://github.com/stackabletech/decisions/issues/84.