-
-
Notifications
You must be signed in to change notification settings - Fork 9
Rework authorization config #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dervoeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM overall, just some nits.
We should provide migration instructions in the release notes for users that use LDAP.
Co-authored-by: Lukas Krug <lukas.voetmand@stackable.tech>
Co-authored-by: Lukas Krug <lukas.voetmand@stackable.tech>
Release notesReworked the authorization configuration for the operator to closer match and represent the Apache NiFi interfaces and implementations. If not provided this defaults to the Breaking changes - Upgrade guideUsers authenticating via LDAP that do not use the Docshttps://docs.stackable.tech/home/nightly/nifi/usage_guide/security/#authorization |
Description
Spike for #792, https://github.com/stackabletech/decisions/issues/66
This consolidates the operators authorization part closer to the nifi internals:
The authorization part consisted of an
OPAandDefaultpart. TheDefaultpart was a mix out of the SingleUser authorizer (e.g. for SingleUser or OIDC authentication) as well as file-based for LDAP authentication.Filebased changes to users or authorizations were not persisted properly (ephermeral) which lead to problems.
This is now consolidated according to the diagram above:
This is breaking for LDAP users that now explicitly have to set the standard authorization method and an initial admin user.
The PVC provided size for the filebased authorization is currently fixed to 16MB and cannot be configured other than pod overrides.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker