Skip to content

fix: remove incorrect disallow_extra check #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gadomski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove incorrect disallow_extra check #760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08897b2
fix: remove incorrect `disalow_extra` check
gadomski Feb 18, 2026
0196622
Merge branch 'main' into issues/759-fewer-than-five-fields
gadomski Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/stac_api_validator/validations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2185,7 +2185,6 @@ def validate_exclude_field(
field: str,
errors: Errors,
warnings: Warnings,
disallow_extra: bool = True,
):
if not body or not (item := first_item(body)):
errors += f"[{context}] : response had no items in response for {desc}"
Expand All @@ -2200,10 +2199,6 @@ def validate_exclude_field(
if value:
errors += f"[{context}] : {desc} response contained '{field}', but should have been excluded"

if disallow_extra:
if len(item) < 5:
errors += f"[{context}] : {desc} response contained fewer than 5 fields {list(item.keys())}"

if Method.GET in search_method_to_url:
_, body, _ = retrieve(
Method.GET,
Expand Down Expand Up @@ -2384,7 +2379,7 @@ def validate_post_case(fields: Any, msg: str):
r_session=r_session,
)
desc = f"GET fields='{field}'"
validate_exclude_field(desc, body, "geometry", errors, warnings, False)
validate_exclude_field(desc, body, "geometry", errors, warnings)
validate_include_field(
desc, body, fields_nested_property, errors, warnings, True
)
Expand Down