Skip to content

Fix undefined set_id error on Configure tab by passing null if parameter is missing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
satyammangroliya wants to merge 1 commit into
base: feature/ilias-9
Choose a base branch
from
Open

Fix undefined set_id error on Configure tab by passing null if parameter is missing #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion classes/UDFCheck/class.UDFCheckGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,15 @@ public function __construct($parent_gui)
$this->pl = ilUserDefaultsPlugin::getInstance();
$this->ctrl->saveParameter($this, self::IDENTIFIER_CATEGORY);
$this->ctrl->saveParameter($this, self::IDENTIFIER);
$this->ctrl->setParameter($this, UserSettingsGUI::IDENTIFIER, $_GET[UserSettingsGUI::IDENTIFIER]);
// When clicking on the "Configure" tab, the set_id may be undefined.
// To prevent errors, we pass a null value if the parameter is not set.
if (isset($_GET[UserSettingsGUI:: IDENTIFIER])) {
$this->ctrl->setParameter($this, UserSettingsGUI::IDENTIFIER, $_GET[UserSettingsGUI::IDENTIFIER]);
}
else{
$this->ctrl->setParameter($this, UserSettingsGUI:: IDENTIFIER, null);
}

$this->ctrl->saveParameter($parent_gui, UserSettingsGUI::IDENTIFIER);
}

Expand Down