Maintenance: Add missing definitions to stub_fd.cc #2340
Closed
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadij
added
M-cleared-for-merge
Contributor
Author
|
NB: maintenance because this is not a bug fix, just removing technical debt found while refactoring other code. |
yadij
commented
Jan 7, 2026
rousskov
changed the title
rousskov
previously requested changes
Jan 7, 2026
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
I adjusted PR title to be more specific.
rousskov
added
S-waiting-for-author
yadij
added
the
S-waiting-for-reviewer
rousskov
removed
the
S-waiting-for-reviewer
rousskov
dismissed
their stale review
I should not insist on improving that moved stub code in this PR.
squid-anubis
pushed a commit
that referenced
this pull request
Jan 17, 2026
Make sure the stub provides all the symbols declared in fd.h
squid-anubis
added
M-waiting-staging-checks
yadij
added
M-cleared-for-merge
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the stub provides all the symbols declared in fd.h