feat(chart): add custom args, hostPathMounts, and devices config#206
Open
aclerici38 wants to merge 2 commits intosquat:mainfrom
Open
feat(chart): add custom args, hostPathMounts, and devices config#206aclerici38 wants to merge 2 commits intosquat:mainfrom
aclerici38 wants to merge 2 commits intosquat:mainfrom
Conversation
Owner
|
Thank you @aclerici38! I need to run this locally to test that the generated manifests are actually produced with the right structure. It will probably make sense to add some kind of testing to the charts soon to validate that they generate correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds configuration for
args,hostPathmounts, anddevicesto the chart.Mounts can be configured under
hostPathMountsin the values. The current default of/devremains unless a mount underhostPathMountsmounts/dev(if someone wants to set readOnly for example) or begins with /dev/. For example if someone adds/dev/tunthe default/devwill be removed.When
devicesis set the default devices args are replaced.Chart version also updated to 0.2.0.
Let me know if this is acceptable, thanks!!