Removing use of global grunt and adding npm build script #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor modernization of the project. You shouldn't require users to have global versions of packages installed. Using npm scripts means the grunt command will be available when the npm script is run. Note the indentation of package.json has changed to two spaces. This is because of the use of the automatic command `npm install --save-dev grunt`. Note any automatic npm command will change the spacing to 2 spaces, so I think it's best to keep it this way. Additionally this adds missing grunt plugins to the packages, which presumably you had installed along with your global grunt.
Owner
|
Closing in favour of #136 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor modernization of the project. You shouldn't require
users to have global versions of packages installed. Using npm scripts
means the grunt command will be available when the npm script is run.
Note the indentation of package.json has changed to two spaces. This is
because of the use of the automatic command
npm install --save-dev grunt. Note any automatic npm command will change the spacing to 2spaces, so I think it's best to keep it this way.
Additionally this adds missing grunt plugins to the packages, which
presumably you had installed along with your global grunt.