Open
Conversation
Copy the approach from Okio.
Collaborator
Author
|
@JakeWharton is this correct for matching Okio? |
JakeWharton
approved these changes
Feb 9, 2026
| } | ||
|
|
||
| extensions.configure<TapmocExtension> { | ||
| // Fail the build if any api dependency exposes incompatible Kotlin metadata, Kotlin stdlib or Java bytecode version. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Fail the build if any api dependency exposes incompatible Kotlin metadata, Kotlin stdlib or Java bytecode version. | |
| // Fail the build if any api dependency exposes incompatible Kotlin metadata, Kotlin stdlib, or Java bytecode version. |
One of my hills...
|
|
||
| # Set to lower version than KGP version to maximize compatibility | ||
| # Default to matching okio | ||
| kotlinCoreLibrariesVersion = "2.1.21" |
Collaborator
There was a problem hiding this comment.
Is there a reason to define this here rather than at the sole usage site?
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the approach from Okio.
square/okio#1770
Closes #9032