Open
Conversation
Collaborator
|
I do wonder whether making this easy is hiding the actual complexity. I feel like merging headers should probably be aware of rules for how to resolve duplicate keys. Or at least documenting that this is the behaviour, and duplicates should be removed before combine if they would make an invalid request |
Contributor
Author
|
Because HTTP headers can be treated as multimap, so I think it's acceptable - or we should create something like |
Contributor
Author
fun Headers.Builder.addIfAbsent(name: String, value: String): Headers.Builder
fun Headers.Builder.addAllIfAbsent(...): Headers.Builder
fun Headers.merge // merge: from Map, withFallback: from typesafe's Config |
Collaborator
|
What's your use case? |
Contributor
Author
|
For example val DEFAULT_UA = headersOf("User-Agent", "Chrome 120...")
Request.Builder().url(...).headers(DEFAULT_UA + headersOf("Authentication", "...")).build() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.