Skip to content

fix: fixed worker1Promiser types, replaced interfaces with types, added stricter tsconfig options, updated worker1Promiser example#156

Merged
tomayac merged 3 commits intosqlite:mainfrom
jurerotar:fix/worker1-promiser
Mar 13, 2026
Merged

fix: fixed worker1Promiser types, replaced interfaces with types, added stricter tsconfig options, updated worker1Promiser example#156
tomayac merged 3 commits intosqlite:mainfrom
jurerotar:fix/worker1-promiser

Conversation

@jurerotar
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just merge this when you're ready

@jurerotar
Copy link
Contributor Author

I am not sure why I expected export default './bin/sqlite3-bundler-friendly.mjs'; to export the module and not a literal ./bin/sqlite3-bundler-friendly.mjs string, but that's what I get for trying to multitask during meetings 😆

We should be good now, I'm running the example we have and it's fully typed 😄

image

Small change I've added, that doesn't affect backwards compatibility is for await promiser('config-get'); to not require a second argument. Previously, we had to provide either {} or undefined, it should work without it now 😄

@jurerotar
Copy link
Contributor Author

@tomayac, just so you're aware, I don't have write privileges, so I can't merge it :(

@tomayac tomayac merged commit f0553ab into sqlite:main Mar 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants