Skip to content

Commit 96dfabd

Browse files
authored
Apply suggestions from code review
1 parent 55760fc commit 96dfabd

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

internal/endtoend/endtoend_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ func TestExamples(t *testing.T) {
5858
t.Parallel()
5959
path := filepath.Join(examples, tc)
6060
var stderr bytes.Buffer
61-
o := &cmd.Options{
62-
Env: cmd.Env{Debug: opts.DebugFromString("")},
61+
opts := &cmd.Options{
62+
Env: cmd.Env{},
6363
Stderr: &stderr,
6464
}
65-
output, err := cmd.Generate(ctx, path, "", o)
65+
output, err := cmd.Generate(ctx, path, "", opts)
6666
if err != nil {
6767
t.Fatalf("sqlc generate failed: %s", stderr.String())
6868
}

internal/endtoend/vet_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"testing"
1313

1414
"github.com/sqlc-dev/sqlc/internal/cmd"
15-
"github.com/sqlc-dev/sqlc/internal/opts"
1615
"github.com/sqlc-dev/sqlc/internal/sqltest"
1716
"github.com/sqlc-dev/sqlc/internal/sqltest/local"
1817
)
@@ -70,11 +69,11 @@ func TestExamplesVet(t *testing.T) {
7069
}
7170

7271
var stderr bytes.Buffer
73-
o := &cmd.Options{
72+
opts := &cmd.Options{
7473
Stderr: &stderr,
75-
Env: cmd.Env{Debug: opts.DebugFromString("")},
74+
Env: cmd.Env{},
7675
}
77-
err := cmd.Vet(ctx, path, "", o)
76+
err := cmd.Vet(ctx, path, "", opts)
7877
if err != nil {
7978
t.Fatalf("sqlc vet failed: %s %s", err, stderr.String())
8079
}

0 commit comments

Comments
 (0)