Skip to content

Commit 55760fc

Browse files
authored
Apply suggestions from code review
1 parent d9df83b commit 55760fc

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

internal/endtoend/endtoend_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ func cmpDirectory(t *testing.T, dir string, actual map[string]string) {
311311
if file.IsDir() {
312312
return nil
313313
}
314-
if !strings.HasSuffix(path, ".go") && !strings.HasSuffix(path, ".kt") && !strings.HasSuffix(path, ".py") && !strings.HasSuffix(path, ".json") && !strings.HasSuffix(path, ".txt") && !strings.HasSuffix(path, ".rs") {
314+
if !strings.HasSuffix(path, ".go") && !strings.HasSuffix(path, ".kt") && !strings.HasSuffix(path, ".py") && !strings.HasSuffix(path, ".json") && !strings.HasSuffix(path, ".txt") {
315315
return nil
316316
}
317317
// TODO: Figure out a better way to ignore certain files
@@ -330,10 +330,6 @@ func cmpDirectory(t *testing.T, dir string, actual map[string]string) {
330330
if strings.HasSuffix(path, "_test.go") || strings.Contains(path, "src/test/") {
331331
return nil
332332
}
333-
// Skip plugin source files - they are not generated by sqlc
334-
if strings.Contains(path, "/plugins/") {
335-
return nil
336-
}
337333
if strings.Contains(path, "/python/.venv") || strings.Contains(path, "/python/src/tests/") ||
338334
strings.HasSuffix(path, "__init__.py") || strings.Contains(path, "/python/src/dbtest/") ||
339335
strings.Contains(path, "/python/.mypy_cache") {

0 commit comments

Comments
 (0)