Skip to content

Fix build issue with latest node version #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billoosijok wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build issue with latest node version #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pre_install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
//https://github.com/mauritslamers/node-canvas-builder/releases/download/v1.0rc3/osx_0.12.tar.gz

var release = "v1.0";
var last_supported_node_version = 7;
var os = require('os');
var fslib = require('fs');
var pathlib = require('path');
Expand All @@ -14,6 +15,10 @@ var node_version = process.versions.node.split(".").filter(function (p, i) {
if (node_version[0] !== '0') {
node_version[1] = '0';
}
// In case the installed version of node does not have a corresponding 'node-canvas-builder'.
if (Number(node_version[0]) > last_supported_node_version) {
node_version[0] = last_supported_node_version;
}
node_version = node_version.join(".");

var arch = os.arch();
Expand Down