Skip to content

fix: scale input amount#168

Open
mj52951 wants to merge 3 commits intomainfrom
fix/scale-input-amounts
Open

fix: scale input amount#168
mj52951 wants to merge 3 commits intomainfrom
fix/scale-input-amounts

Conversation

@mj52951
Copy link
Copy Markdown

@mj52951 mj52951 commented Apr 1, 2026

In case of different decimals for input and output token, we need to properly scale input amount. Fixes made for across and lifi, similar edge case errors exist on mayan and rhinestone but didn't bother resolving them as they're not used.
Please double check could this break something else or are there more cases of this that I might've missed.

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Go Test coverage is 53.1 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 previously approved these changes Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Go Test coverage is 53.1 %\ ✨ ✨ ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants