Add EdDSA support to NimbusJwtEncoder#19175
Conversation
NimbusJwtEncoder did not support EdDSA family algorithms. This commit adds support for signing JWTs with EdDSA keys. Closes: spring-projectsgh-17098 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
| /** | ||
| * EdDSA signature algorithms using Ed448 curve (optional). | ||
| */ | ||
| ED448(JwsAlgorithms.ED448), |
There was a problem hiding this comment.
I think we should support this too.
There was a problem hiding this comment.
A small note: ED448 should be listed after ED25519, as the latter is based on the prime 2^255 - 19 and offers ~128 bits of security (similar to PS256), while the former is based on the larger prime 2^448 - 2^224 - 1, and offers ~224 bits of security (between PS384 and PS512).
I think listing ED448 before ED25519 could give the wrong impression that it is cryptographically weaker.
There was a problem hiding this comment.
Thanks, that is a very good point. Exactly the same thing is done in com.nimbusds.jose.JWSAlgorithm.
|
An interesting observation: Nimbus uses |
Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
3 participants
NimbusJwtEncoder did not support EdDSA family algorithms. This commit adds support for signing JWTs with EdDSA keys.
Closes: gh-17098
Note: This is still a WIP and tests are still failing.