fix: Add issuer URI to GitHub OAuth provider for RFC 9207 compliance#19058
fix: Add issuer URI to GitHub OAuth provider for RFC 9207 compliance#19058Vinay152003 wants to merge 2 commits intospring-projects:mainfrom
Conversation
GitHub silently enabled RFC 9207 (OAuth 2.0 Authorization Server Issuer Identification) between April 6-10, 2026, which breaks GitHub OAuth authentication in frameworks that validate the issuer field. This fix adds the issuer URI to the GitHub OAuth provider configuration in Spring Security to ensure RFC 9207 compliance. Issue: langfuse/langfuse#13091 RFC 9207: https://datatracker.ietf.org/doc/html/rfc9207 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: Vinay Hipparge <vinayhipparge@gmail.com>
9e27bbb to
11ba525
Compare
|
Hi @jgrandja @jzheaux - requesting a review on this PR. Summary: Changes:
Related Issue:
This is affecting multiple frameworks across the ecosystem (NextAuth.js, oauth2-proxy, Langfuse, etc.). DCO checks are now passing ✅. Ready for review whenever you have time. Thanks! |
|
The
Why do you think there is a bug? Did you get a chance to review |
Add test to verify that CommonOAuth2Provider.GITHUB configures the issuerUri required for RFC 9207 iss parameter validation. GitHub enabled RFC 9207 (OAuth 2.0 Authorization Server Issuer Identification) which causes all GitHub OAuth sign-ins to fail when no issuerUri is configured. This test ensures the fix is in place and guards against regression. Signed-off-by: Vinay Hipparge <vinayhipparge@gmail.com>
|
@jgrandja Thank you for the detailed review and for engaging on this PR. Why This Is a BugGitHub silently enabled RFC 9207 (OAuth 2.0 Authorization Server Issuer Identification) on April 9, 2026. The When Spring Security's The bug: Without an explicit
ClientRegistrations ReviewI reviewed Test CaseI have now added two tests to
Related Issues & Evidence
|
Summary
GitHub silently enabled RFC 9207 (OAuth 2.0 Authorization Server Issuer Identification) between April 6-10, 2026, breaking GitHub OAuth authentication in frameworks that validate the issuer field.
This fix adds the issuer URI to the GitHub OAuth provider configuration in Spring Security to ensure RFC 9207 compliance.
Changes
References