Refine upgradeEncoding condition in DaoAuthenticationProvider#18788
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Refine upgradeEncoding condition in DaoAuthenticationProvider#18788therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
After adding jspecify support in the module that contains the DaoAuthenticationProvider class, we actually changed the contract logic, which is a good thing, and this commit fixes it. Closes: spring-projectsgh-18781 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Feb 23, 2026
Comment on lines
-134
to
+137
| boolean upgradeEncoding = existingEncodedPassword != null && this.userDetailsPasswordService != null | ||
| boolean upgradeEncoding = existingEncodedPassword != null | ||
| && !Objects.equals(this.userDetailsPasswordService, UserDetailsPasswordService.NOOP) |
Contributor
Author
There was a problem hiding this comment.
Since this problem, I believe, is directly related to semantics, I assume we don’t need tests for this?
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding jspecify support in the module that contains the DaoAuthenticationProvider class, we actually changed the contract logic, which is a good thing, and this commit fixes it.
Closes: gh-18781