Warn when securityMatcher misses oauth2Login URLs#18759
Open
wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
Open
Warn when securityMatcher misses oauth2Login URLs#18759wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
wonderfulrosemari wants to merge 1 commit intospring-projects:mainfrom
Conversation
Share HttpSecurity request matcher with configurers and use it in\nOAuth2LoginConfigurer to log a warning when oauth2Login endpoints are\noutside the configured securityMatcher.\n\nAdd tests for both warning and non-warning cases.\n\nCloses spring-projectsgh-14096 Signed-off-by: wonderfulrosemari <whwlsgur1419@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-14096
When
oauth2Login()is configured together with a restrictivesecurityMatcher, it is easy to accidentally exclude one of the OAuth2 login endpoints, which can lead to 404 responses.This change adds a warning when the configured
securityMatcherdoes not match OAuth2 login endpoints.Changes include:
HttpSecurityrequest matcher as a shared objectOAuth2LoginConfigurer, warn whensecurityMatcherdoes not match:/oauth2/authorization/{registrationId}by default)/login/oauth2/code/*by default, or a custom redirection endpoint base URI)