Skip to content

Update request-matcher XML property to support PathPatternRequestMatcher#18737

Merged
jzheaux merged 1 commit intospring-projects:7.0.xfrom
meliezer:gh-18641
Feb 26, 2026
Merged

Update request-matcher XML property to support PathPatternRequestMatcher#18737
jzheaux merged 1 commit intospring-projects:7.0.xfrom
meliezer:gh-18641

Conversation

@meliezer
Copy link
Contributor

This PR updates the request-matcher schema to reflect the current supported matcher values.

  • Adds path and removes legacy mvc/ant from the schema
  • Updates XML test resources that use request-matcher="mvc"/"ant" to use path

The .xsd file was generated from the updated .rnc using:
./gradlew :spring-security-config:rncToXsd

Fixes #18641.

Note: XML test resource filenames still reference mvc/ant. A follow-up cleanup issue #18736 has been opened to evaluate whether these resources and the related tests should be removed or updated, as this is outside the scope of this PR.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 13, 2026
@jzheaux jzheaux self-assigned this Feb 25, 2026
@jzheaux jzheaux added in: config An issue in spring-security-config type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2026
@jzheaux jzheaux added this to the 6.5.9 milestone Feb 25, 2026
@jzheaux jzheaux modified the milestones: 6.5.9, 7.0.4 Feb 26, 2026
@jzheaux
Copy link
Contributor

jzheaux commented Feb 26, 2026

Thanks for the PR, @meliezer! I've rebased it onto 7.0.x so that folks can have the support earlier.

I've also opened #18807 to investigate the possibility of backporting support for request-matcher="path" to 6.5.x to further simplify migration.

@jzheaux jzheaux changed the base branch from main to 7.0.x February 26, 2026 21:26
Closes spring-projectsgh-18641

Signed-off-by: Menashe Eliezer <menashe.eliezer@gmail.com>
@jzheaux jzheaux changed the title Update request-matcher schema and XML tests to use path Update request-matcher XML property to support PathPatternRequestMatcher Feb 26, 2026
@jzheaux jzheaux enabled auto-merge (rebase) February 26, 2026 21:28
@jzheaux jzheaux merged commit ee97c83 into spring-projects:7.0.x Feb 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: config An issue in spring-security-config type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spring-security.xsd schema validates request-matcher incorrectly

3 participants