Clarify behavior when multiple CorsConfigurationSource beans are present#18584
Open
mjkang4416 wants to merge 1 commit intospring-projects:mainfrom
Open
Clarify behavior when multiple CorsConfigurationSource beans are present#18584mjkang4416 wants to merge 1 commit intospring-projects:mainfrom
mjkang4416 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Document that Spring Security does not automatically select a CorsConfigurationSource when multiple candidates are present and that users must explicitly configure which one to use. Signed-off-by: 강민정 <133966179+mjkang4416@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When more than one
CorsConfigurationSourcebean is present in the application context,Spring Security fails to start with an ambiguous bean definition error.
From a user’s perspective, this is confusing because a custom
CorsConfigurationSourcebean may already be defined, yet Spring Securitydoes not indicate which one it expects to use.
The current CORS section of the reference documentation does not describe
what happens when multiple
CorsConfigurationSourcebeans are present.Changes in this PR
This PR updates the CORS section of the Spring Security reference documentation to:
CorsConfigurationSourcewhen multiple candidates are available.@Qualifier,@Primary, or the.cors()DSL.Related Issue
Fixes #18583