Add reactive handle method to ServerCsrfTokenRequestHandler#18558
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Add reactive handle method to ServerCsrfTokenRequestHandler#18558therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks for the PR! Unfortunately, the changes in this pull request are not passive and we cannot accept it as it is. For this to be accepted, we cannot change the method signature. Instead, you probably need to:
Are you able to update the PR accordingly? |
rwinch
added
status: waiting-for-feedback
Contributor
Author
|
Sure, I will update the PR ASAP |
spring-projects-issues
added
status: feedback-provided
rwinch
added
status: waiting-for-feedback
therepanic
changed the title
therepanic
commented
Jan 25, 2026
Comment on lines
+49
to
+60
| /** | ||
| * Handles a request using a {@link CsrfToken}. | ||
| * @param exchange the {@code ServerWebExchange} with the request being handled | ||
| * @param csrfToken the {@code Mono<CsrfToken>} created by the | ||
| * {@link ServerCsrfTokenRepository} | ||
| * @return a {@code Mono} that completes when handling is finished | ||
| */ | ||
| default Mono<Void> handleAsync(ServerWebExchange exchange, Mono<CsrfToken> csrfToken) { | ||
| handle(exchange, csrfToken); | ||
| return Mono.empty(); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Will this method name suit us?
Adds a default reactive handle method returning Mono<Void> and deprecates the legacy void handle method in preparation for Spring Security 8. Closes: spring-projectsgh-16869 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Contributor
Author
|
Flaky test I guess? |
spring-projects-issues
added
status: feedback-provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning Mono from
ServerCsrfTokenRequestHandler#handlewould allow non-blocking response writes.Closes: gh-16869