GH-1513 - Propagate delegate when executor threads are already created#1552
Open
raoulvdberge wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: raoulvdberge <raoulvdberge@gmail.com>
raoulvdberge
force-pushed
the
1513-propagate-delegate-when-executor-threads-are-already-created
branch
2 times, most recently
from
2798f70 to
be18636
Compare
… main thread in case the task threads are initialized already There is an ordering issue: when task threads are created before `ThreadBoundApplicationListenerAdapter` is initialized, `InheritableThreadLocal` values are not propagated. As a result, later events bypass the test context. Because thread creation timing is nondeterministic, this leads to flaky tests as expected events are not detected. Fixes spring-projectsGH-1513 Signed-off-by: raoulvdberge <raoulvdberge@gmail.com>
raoulvdberge
force-pushed
the
1513-propagate-delegate-when-executor-threads-are-already-created
branch
from
be18636 to
dafff51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an ordering issue: when task threads are created before
ThreadBoundApplicationListenerAdapteris initialized,InheritableThreadLocalvalues are not propagated.As a result, later events bypass the test context. Because thread creation timing is nondeterministic, this leads to flaky tests as expected events are not detected.
Fixes GH-1513