fix(web): handle HttpMessageNotWritableException in DisconnectedClien…#36615
Open
dahyvuun wants to merge 1 commit intospring-projects:mainfrom
Open
fix(web): handle HttpMessageNotWritableException in DisconnectedClien…#36615dahyvuun wants to merge 1 commit intospring-projects:mainfrom
dahyvuun wants to merge 1 commit intospring-projects:mainfrom
Conversation
dahyvuun
force-pushed
the
fix/disconnected-client-http-message-not-writable
branch
from
e0e0343 to
3a00365
Compare
spring-projects-issues
added
the
status: waiting-for-triage
dahyvuun
force-pushed
the
fix/disconnected-client-http-message-not-writable
branch
from
3a00365 to
dcb1920
Compare
…tHelper Signed-off-by: dahyvuun <dahyvuun@gmail.com>
dahyvuun
force-pushed
the
fix/disconnected-client-http-message-not-writable
branch
from
dcb1920 to
4fc38d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a client disconnects,
@ExceptionHandlerattempts to write a response, resulting inHttpMessageNotWritableExceptionwrapping anIOException: The response may not be written to once it has been closed. This exception is not recognized byDisconnectedClientHelperand propagates to the Servlet container unnecessarily.Solution
Add
"response may not be written"to theEXCEPTION_PHRASESset inDisconnectedClientHelperso that this scenario is silently logged at DEBUG level instead of propagating.Closes #36421