Allow customization of the ProxyFactory in HttpServiceProxyFactory used to create HTTP service proxies#36225
Closed
dungdm93 wants to merge 1 commit intospring-projects:mainfrom
Closed
Conversation
456e119 to
c5ec8a0
Compare
HttpServiceProxyFactory customize ProxyFactory prior to proxy bean creationProxyFactory in HttpServiceProxyFactory to create HTTP service proxies
ProxyFactory in HttpServiceProxyFactory to create HTTP service proxiesProxyFactory in HttpServiceProxyFactory used to create HTTP service proxies
rstoyanchev
requested changes
Jan 29, 2026
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
Thanks for the suggestion. The request makes sense, however I would update the implementation a bit as suggested below. Having at least one test would also be a good idea.
Please, let me know if you will make those updates.
...web/src/main/java/org/springframework/web/service/invoker/HttpServiceProxyPostProcessor.java
Outdated
Show resolved
Hide resolved
...web/src/main/java/org/springframework/web/service/invoker/HttpServiceProxyPostProcessor.java
Outdated
Show resolved
Hide resolved
c5ec8a0 to
00bec12
Compare
…actory` before creating the proxy Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
00bec12 to
b2d9da4
Compare
Contributor
Author
|
@rstoyanchev I update PR as your suggestion, could you please take a look. |
rstoyanchev
pushed a commit
that referenced
this pull request
Feb 4, 2026
Allows manipulating the `ProxyFactory` before the proxy is created See gh-36225 Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spring Data project provides support for
RepositoryProxyPostProcessor, which allows customization of the underlyingProxyFactory(e.g, registering additional interceptors) prior to proxy bean creation.In contrast,
HttpServiceProxyFactory, which is responsible for creating client proxies from HTTP service interfaces annotated with@HttpExchange, currently does not offer a straightforward extension point for registering interceptors (e.g., for tracing or cross-cutting concerns).Example usage of
HttpServiceProxyFactory.ProxyFactoryCustomizer: