Skip to content

Conversation

@RealTake
Copy link

  • Unified single bean initialization methods into initSingleBean, removing duplicate logic.
  • Consolidated list bean initialization methods into initListBeans, streamlining flag handling and default strategy.

- Unified single bean initialization methods into initSingleBean, removing duplicate logic.
- Consolidated list bean initialization methods into initListBeans, streamlining flag handling and default strategy.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 22, 2025
Copy link

@mikelhamer mikelhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My overall impression is that while reducing duplication is good in theory, the changes here combine several focused, purpose-specific methods into one general method. Over time this will make the behavior harder to modify, because a single method now has to handle every scenario. It also takes a large number of parameters and still requires passing in a function to customize behavior, which suggests the method is doing too much. Sometimes duplication is the price we willingly pay for clarity, isolation, stability, and ease of change. Over generalizing can end up being more costly than a few repeated lines.

@bclozel
Copy link
Member

bclozel commented Dec 17, 2025

I agree that while reducing duplication, this makes the code harder to read and debug here. DispatcherServlet is an important piece of infrastructure and I'd rather not introduce complexity there for cosmetic changes.

Also, DCO is not signed so we cannot accept this contribution anyway.

@bclozel bclozel closed this Dec 17, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants