Add support for BINARY (BYTEA) column type in JdbcOAuth2AuthorizationService#2337
Open
s-chan-o wants to merge 1 commit into
Open
Add support for BINARY (BYTEA) column type in JdbcOAuth2AuthorizationService#2337s-chan-o wants to merge 1 commit into
s-chan-o wants to merge 1 commit into
Conversation
…Service PostgreSQL uses BYTEA for binary data, which is reported by the JDBC driver as Types.BINARY (-2). The JdbcOAuth2AuthorizationService only handled Types.BLOB and Types.CLOB, causing failures when used with PostgreSQL (and compatible databases such as AWS Aurora DSQL). This commit adds handling for Types.BINARY in three places: - getLobValue: reads bytes and converts to String, trimming trailing null bytes that may be present with fixed-length BINARY columns - doSetValue: writes byte[] or String values via the LobCreator - mapToSqlParameter: converts String values to byte[] for BINARY columns Fixes spring-projectsgh-2321
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JdbcOAuth2AuthorizationServicefails when PostgreSQL (or PostgreSQL-compatible databases such as AWS Aurora DSQL) is used as the backend store.PostgreSQL represents binary data using the
BYTEAtype, which is reported by the JDBC driver asTypes.BINARY(-2). The current implementation only handlesTypes.BLOBandTypes.CLOB, so BYTEA columns cause data read/write failures.Fixes gh-2321
Changes
Added
Types.BINARYhandling in three locations withinJdbcOAuth2AuthorizationService:getLobValueString; trims trailing null bytes present in fixed-lengthBINARYcolumnsdoSetValuebyte[]orStringvalues viaLobCreatorforTypes.BINARYparametersmapToSqlParameterStringvalues tobyte[]when the column type isTypes.BINARYTesting
custom-oauth2-authorization-schema-binary-data-type.sqlwithbinary(10000)column definitions (HSQL equivalent of PostgreSQL BYTEA, mapping toTypes.BINARY)tableDefinitionWhenBinarySqlTypeThenAuthorizationUpdated()test following the same pattern as the existing CLOB test