GH-3164 Support multiple StreamsBuilderFactoryBeanConfigurers#3192
Open
wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
Open
GH-3164 Support multiple StreamsBuilderFactoryBeanConfigurers#3192wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
Conversation
…rers Signed-off-by: wadhwaroh-lang <wadhwa.roh@gmail.com>
wadhwaroh-lang
force-pushed
the
fix/3164-multiple-streams-builder-configurers
branch
from
ef36e2d to
b3ee0c0
Compare
Contributor
Author
|
hi @olegz and team if you can review please. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3164
This updates the Kafka Streams binder to apply all available
StreamsBuilderFactoryBeanConfigurerbeans instead of usinggetIfUnique(), which returnsnullwhen more than one configurer is present.This allows applications to combine user-defined configurers with framework-provided configurers, such as Spring Boot Kafka metrics configuration.
Changes:
StreamsBuilderFactoryBeanConfigurerbeans from the provider.StreamsBuilderFactoryBean.Tests:
./mvnw -pl binders/kafka-binder/spring-cloud-stream-binder-kafka-streams -Dtest=KafkaStreamsBinderSupportAutoConfigurationTests test