Skip to content

Docs: Document required dependency for JsonToGrpc filter #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ava051213 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Docs: Document required dependency for JsonToGrpc filter #4152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...ng-cloud-gateway-server-webflux/gatewayfilter-factories/jsontogrpc-factory.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ src/main/resources/proto/hello.proto

NOTE: `streaming` is not supported.

=== Required Dependencies
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title is using a level-3 heading (===) even though this page doesn’t define any level-2 sections (==). That will nest this content oddly in the rendered docs/TOC. Use a level-2 heading (== Required Dependencies) instead (consistent with other GatewayFilter factory pages which don’t use === headings).

Suggested change
=== Required Dependencies
== Required Dependencies

Copilot uses AI. Check for mistakes.

To use the `JsonToGrpc` filter, add the following dependencies:
Comment on lines +25 to +27
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence refers to “dependencies” but only a single dependency is listed below. Update the wording to “dependency” to match the example.

Suggested change
=== Required Dependencies
To use the `JsonToGrpc` filter, add the following dependencies:
=== Required Dependency
To use the `JsonToGrpc` filter, add the following dependency:

Copilot uses AI. Check for mistakes.

[source,xml]
----
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-protobuf</artifactId>
</dependency>
----


*application.yml.*

Expand Down