docs: Add required dependencies for JsonToGrpc filter#4117
Open
Tarte12 wants to merge 1 commit intospring-cloud:mainfrom
Open
docs: Add required dependencies for JsonToGrpc filter#4117Tarte12 wants to merge 1 commit intospring-cloud:mainfrom
Tarte12 wants to merge 1 commit intospring-cloud:mainfrom
Conversation
The JsonToGrpc GatewayFilter relies on several optional dependencies that are not included transitively. Without them, users encounter a NoClassDefFoundError at runtime when the filter is invoked. Documented required dependencies: - io.grpc:grpc-netty - io.grpc:grpc-protobuf - io.grpc:grpc-stub - com.google.protobuf:protobuf-java-util Fixes spring-cloudgh-3424 Signed-off-by: Tarte <emprimula@gmail.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the
JsonToGrpcGatewayFilter, users encounter aNoClassDefFoundErrorat runtime because the required dependencies are not included transitively (they are declared asoptionalinspring-cloud-gateway-server-webflux). This was not documented anywhere.Closes #3424
Solution
Added a Required Dependencies section to the
JsonToGrpcfilter documentation listing the four dependencies that must be explicitly added:io.grpc:grpc-nettyio.grpc:grpc-protobufio.grpc:grpc-stubcom.google.protobuf:protobuf-java-util