Replace hardcoded return type check with BiPredicate in AbstractGatewayDiscoverer#4043
Open
abrxu wants to merge 1 commit intospring-cloud:mainfrom
Open
Replace hardcoded return type check with BiPredicate in AbstractGatewayDiscoverer#4043abrxu wants to merge 1 commit intospring-cloud:mainfrom
abrxu wants to merge 1 commit intospring-cloud:mainfrom
Conversation
…ayDiscoverer Add overloaded doDiscover method that accepts a BiPredicate<Class<R>, Method> to allow flexible method filtering. The original method delegates to the new one with the default predicate behavior (isAssignableFrom check). Signed-off-by: abrxu <abrxu@yahoo.com>
Member
|
Are you running into a problem because of it, or just addressing the TODO? |
Author
Just addressing the TODO. I noticed it while exploring the codebase and thought it would be a good first contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overloaded
doDiscovermethod that accepts aBiPredicate<Class<R>, Method>for flexible method filtering - Original method delegates to the new one with default behavior (isAssignableFrom check) - Resolves TODO comment in AbstractGatewayDiscovererTests