Prevent loadbalancer filter to wrap exception into RuntimeException#4020
Open
ComputerDaddyGuy wants to merge 1 commit intospring-cloud:mainfrom
Open
Prevent loadbalancer filter to wrap exception into RuntimeException#4020ComputerDaddyGuy wants to merge 1 commit intospring-cloud:mainfrom
ComputerDaddyGuy wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: Samuel SCHNEGG <samuel.schnegg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior
lbfilter catches anyExceptionthrown from subsequent filters. After processing, the exception is rethrown but wrapped into aRuntimeExceptionIssue
RuntimeExceptionprevents error handlers to catch the original exceptionProposed solution in this PR
lbfilter has been adapted to use an anonymous class instead of a lambdalbfilter does not wrap the original exception