The X-Consul-Token request header is always optional#971
The X-Consul-Token request header is always optional#971wombleabroad wants to merge 5 commits intospring-cloud:mainfrom
Conversation
Fixes spring-cloud#970 The `agentServiceDeregister` and `agentServiceSetMaintenance` operations within `ConsulClient` both required a Consul ACL token passed via the X-Consul-Token request header. This header is now optional, consistent with all other token-based operations within this interface.
|
Can you sign your commit so the DCO check passes? |
Fixes spring-cloud#970 The `agentServiceDeregister` and `agentServiceSetMaintenance` operations within `ConsulClient` both required a Consul ACL token passed via the X-Consul-Token request header. This header is now optional, consistent with all other token-based operations within this interface. Signed-off-by: Gareth Davies <womble.abroad@gmail.com>
…token-header-always-optional' into feature/client-acl-token-header-always-optional
|
Ugh, that was ugly, sorry. It's been a long time since I last amended a commit. |
|
No worries but the commits still are not signed |
|
Are you talking about GPG-signing? I thought the DCO was complaining about the missing "Signed-off-by: Gareth Davies womble.abroad@gmail.com" line, which I added as part of ce85796. If you need a GPG signature, I'll decline this PR and generate a new one. I don't want to mess around with Git commit history. |
|
This is why the DCO is failing
|
|
Oh, because I used my work laptop to make the change. Let me double-check my company's guidance on contributing to open-source projects. I may need to switch to my personal laptop... |
The `agentServiceDeregister` and `agentServiceSetMaintenance` operations within `ConsulClient` both required a Consul ACL token passed via the X-Consul-Token request header. This header is now optional, consistent with all other token-based operations within this interface. Signed-off-by: Gareth Davies <gareth.i.davies@spectrum.com>
…token-header-always-optional' into feature/client-acl-token-header-always-optional
|
@ryanjbaxter, I'm declining this PR and will submit a new (cleaner) one from my personal account. |
wombleabroad
deleted the
feature/client-acl-token-header-always-optional
branch
3 participants
Fixes #970
The
agentServiceDeregisterandagentServiceSetMaintenanceoperations withinConsulClientboth required a Consul ACL token passed via the X-Consul-Token request header. This header is now optional, consistent with all other token-based operations within this interface.