LoggingSystemShutdownListener ClassLoader#972
Open
jaminh wants to merge 1 commit intospring-cloud:mainfrom
Open
LoggingSystemShutdownListener ClassLoader#972jaminh wants to merge 1 commit intospring-cloud:mainfrom
jaminh wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Use the ClassLoader from the SpringApplication if available.
jaminh
force-pushed
the
log-sys-listener-classloader
branch
from
9d9d81d to
a551f42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the ClassLoader from the SpringApplication if available.
This is related to spring-projects/spring-boot#26126. If the SpringApplication is created with a different classloader that can create issues for the LoggingSystemShutdownListener since it may end up using a different classloader than the one the SpringApplication is using.