feat: add resolver_version field to TelemetryData#346
Merged
fabriziodemaria merged 4 commits intomainfrom Mar 20, 2026
Merged
Conversation
The new field carries the confidence-resolver crate version (e.g. "0.14.0") so the backend can reliably detect whether the WASM supports TelemetryData.resolve_rate and skip the legacy resolve-count metric path. Made-with: Cursor
fabriziodemaria
changed the title
Made-with: Cursor
nicklasl
reviewed
Mar 20, 2026
Replace `env!("CARGO_PKG_VERSION")` with a hardcoded constant in
`version.rs` managed by release-please, so the resolver version
is stored in the binary without relying on the host build environment.
Made-with: Cursor
Made-with: Cursor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string resolver_version = 8field toTelemetryDatain the internal proto, populated from the crate version (CARGO_PKG_VERSION) at build time.epx-flags-resolver) a reliable signal to detect whether the embedded resolver supportsTelemetryData.resolve_rate, replacing the fragilememory_bytes > 0heuristic.Context
The WASM resolver sends resolve-rate data via two paths: the newer
TelemetryData.resolve_rateand the legacyFlagResolveInfo. The backend needs to skip the legacy metric when the new path is active to avoid double-counting. An explicit version field is a much more reliable capability signal than checkingmemory_bytes > 0.Test plan
cargo checkpassesMade with Cursor