[draft] : Remove MonitoringConsole code from all test files to reduce flakiness #1678
+262
−3,015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all MonitoringConsole deployment, verification, and configuration code from test files outside the dedicated monitoring_console directory. This change reduces test flakiness by eliminating MC dependencies. Changes: - Removed DeployMonitoringConsole and VerifyMonitoringConsoleReady calls - Removed MC deployment specs (mcSpec, mc variable) - Removed MC app uploads and app framework configurations - Removed MonitoringConsoleRef from CR specs - Removed MC resource version tracking - Removed MC from app source info arrays and verification checks - Updated config map Expect checks to exclude MC - Cleaned up orphaned MC-related variables and comments Affected test suites: - Secret tests (6 files) - License Manager tests (3 files) - License Master tests (3 files) - Custom Resource CRUD tests (5 files) - App Framework tests - AWS, GCP, Azure (15 files) Total: 32 test files modified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
CLA Assistant Lite bot: All contributors have NOT signed the COC Document I have read the Code of Conduct and I hereby accept the Terms You can retrigger this bot by commenting recheck in this Pull Request |
Contributor
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Collaborator
|
Why are we removeing those tests? Are they duplicated somewhere? In principal I would prefer to fix flaky tests, not remove them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all MonitoringConsole deployment, verification, and configuration code from test files outside the dedicated monitoring_console directory. This change reduces test flakiness by eliminating MC dependencies.
Changes:
Affected test suites:
Total: 32 test files modified
🤖 Generated with Claude Code
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist