Feat/proper cloud provider polymorhism and dataclass for Backend params#1372
Open
cichyx96 wants to merge 2 commits intosplunk:developfrom
Open
Feat/proper cloud provider polymorhism and dataclass for Backend params#1372cichyx96 wants to merge 2 commits intosplunk:developfrom
cichyx96 wants to merge 2 commits intosplunk:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exisiting code used polymorhism forcing classes AWSProvider, AzureProvider and GCPProvider to implement set of functions like create_backend and delete_backend, however I noticed those functions were not used in code, instead backend_manager did all logic. I have refactored this to reduce lines of code and utilize existing logic.
Also I have added new dataclass BackendParams. This allows to easily understand what backend configuration consist of and avoid errors like 'KeyError'.
60 lines of code less to maintain :)
[x] Test passed
[x] Successfully provisioned splunk_minimal_aws after changes (in AWS)