Skip to content

Update windows service to support DLL and EXE#2152

Draft
hulto wants to merge 1 commit intomainfrom
jules-windows-service-dll-5468431601370590240
Draft

Update windows service to support DLL and EXE#2152
hulto wants to merge 1 commit intomainfrom
jules-windows-service-dll-5468431601370590240

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Mar 29, 2026

This commit fixes the Windows service to support being run as a shared process DLL. By checking if the current process is running under svchost.exe, the implant now correctly reports its service type as ServiceType::SHARE_PROCESS when it's a DLL. When running as a standalone executable, it uses ServiceType::OWN_PROCESS. The main.eldritch installer script has also been updated to configure sc.exe create with type= share when installing a DLL or specifying svchost.exe.


PR created automatically by Jules for task 5468431601370590240 started by @hulto

- Detects if running under `svchost.exe` to use `ServiceType::SHARE_PROCESS` instead of `ServiceType::OWN_PROCESS`
- Updates `install_service/main.eldritch` to detect `.dll` or `svchost.exe` paths and set `type= share` instead of `type= own` for `sc.exe create`

Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2893 2893 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1904 2893 2893 0 0 0 0 41.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2893 0 0 6.0s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.0s 6.0s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 4.2s 4.2s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant