Skip to content

[AI] Fix Typos #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KCarretto wants to merge 1 commit into from
Closed

[AI] Fix Typos #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tavern/internal/builder/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The builder package orchestrates agent compilation for target platforms. It conn

### future
- Add terraform for build server
- Register redirectors so bulider callback uri can be a drop down.
- Register redirectors so builder callback uri can be a drop down.
- Modifying the agent IMIX_CONFIG currently requires changes to both imix and tavern code bases now. Is there a way to codegen a YAML spec from tavern to the agent?
- De-dupe agent builds should the API stop builds that have the same params and point to the existing build? Or is this a UI thing?

Expand All @@ -25,15 +25,15 @@ The builder package orchestrates agent compilation for target platforms. It conn
- Change exit Code to a bool and rename to errored to
- Where should realm source code be pulled?
- which version'd copy of the code to checkout
- Can we automatically determine which version / main,edge the server is and pass that ot the build script.
- Can we automatically determine which version / main,edge the server is and pass that to the build script.
- Ship tavern with imix source code embedded?
- Hard for teams to bring their own changes.

- Update schema for UX
- Target OS + Target Format ---> rust target
- TargetOS's only support certain formats
- where to get the realm source code from - pull public repo?
- Currentt pattern with arbitrary bulid script is RCE as a service. Scope and limit this to just build configuration options.
- Current pattern with arbitrary build script is RCE as a service. Scope and limit this to just build configuration options.
- upstream should be free form
- pubkey can be set by the server
## Overview
Expand Down
1 change: 0 additions & 1 deletion tavern/internal/c2/c2pb/c2.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions tavern/internal/graphql/quest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package graphql

type outputErrorPair struct {
Output string
Error string
HasFile bool
HasProcess bool
Output string
Error string
HasFile bool
HasProcess bool
}
2 changes: 1 addition & 1 deletion tavern/internal/http/shell/websocket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const (
type WebsocketControlFlowSignal string

// WebsocketControlFlowSignalPortalUpgrade indicates that the connection has been upgraded to use a portal for interactivity.
// WebsocketControlFlowSignalPortalDowngrade indicates that the connection has been downgraded to a non-interactive polling model, indicating that the portal has closed or is unuseable.
// WebsocketControlFlowSignalPortalDowngrade indicates that the connection has been downgraded to a non-interactive polling model, indicating that the portal has closed or is unusable.
const (
WebsocketControlFlowSignalPortalUpgrade = "PORTAL_UPGRADE"
WebsocketControlFlowSignalPortalDowngrade = "PORTAL_DOWNGRADE"
Expand Down
Loading